fix(geo): handle Null Shapes in shapefile uploads #1539
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace shpjs with shapefile library for parsing uploaded shapefiles. shpjs crashes with "offset out of range" error when encountering Null Shapes (type 0), which are valid but empty geometry records. The shapefile library correctly handles these by returning features with null geometry, which we now filter out before processing. Also add diagnostic tools for analyzing problematic shapefiles.
Contributor
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
loicguillois
temporarily deployed
to
pr1539-front
GitHub Actions
Inactive
loicguillois
temporarily deployed
to
pr1539-api
GitHub Actions
Inactive
loicguillois
temporarily deployed
to
pr1539-queue
GitHub Actions
Inactive
Add proj4 library to reproject shapefile coordinates from projected coordinate systems (Lambert 93, UTM zones for DOM-TOM) to WGS84. - Detect projection from .prj file (WKT format) - Auto-detect projection from coordinate ranges when .prj is missing - Support common French projections: EPSG:2154, 2975, 5490, 32620, 2972, 4471 - Add test script for verifying reprojection
…ections Some shapefiles from Réunion use a modified coordinate system with additional offsets (X+1.35M, Y+1.57M on top of standard UTM 40S). This causes coordinates to appear in the ocean when reprojected. Added REUNION_OFFSET projection detection for coordinates in range X: 1.6M-1.9M, Y: 9.0M-9.5M, which applies the necessary offsets before UTM 40S reprojection.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problème
L'upload de certains shapefiles échoue avec l'erreur :
De plus, les coordonnées importées ne sont pas converties en WGS84 (lat/lng), ce qui empêche l'affichage correct des périmètres sur la carte.
Cause
shpjsne gère pas les Null Shapes (type 0)Solution
1. Remplacement de shpjs par shapefile
La bibliothèque
shapefilegère correctement les Null Shapes en retournant des features avecgeometry: nullque nous filtrons.2. Ajout de la reprojection automatique
.prjpour détecter la projection source (format WKT).prjabsentproj4Projections supportées :
Fichiers modifiés
proj4Scripts de diagnostic
tools/analyze-shapefile.ts- Analyse détaillée d'un shapefiletools/test-shapefile-fix.ts- Test avant/après pour le fix Null Shapestools/test-reprojection.ts- Test de reprojection des coordonnéesTests
Remarque importante
.prjdans le shapefile.